Fix: Handle invalid dates in serialization - #3554
Closed
trentonallan wants to merge 8 commits into
Closed
trentonallan wants to merge 8 commits into
trentonallan wants to merge 8 commits into
Conversation
Collaborator
|
waste of maintainer time with incorrect AI-generated pull request, exhibit n A correct implementation is already available in #3330. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3318
Problem
new Date(undefined)and other invalid dates were being serialized as "0NaN-NaN-NaNTNaN:NaN:NaN.NaN+NaN:NaN" instead of being handled properly.Solution
Added validation in
dateToStringanddateToStringUTCfunctions to check if date is valid before serialization usingisNaN(date.getTime()). Invalid dates now throw a TypeError with a clear error message.Testing